Include dataset_id, table_id, poll_interval in BigQueryIntervalCheckTrigger serialization#66990
Closed
abhid-007 wants to merge 1 commit into
Closed
Conversation
…rigger serialization `BigQueryIntervalCheckTrigger.__init__` accepts `dataset_id`, `table_id`, and `poll_interval` and stores them via the parent class, but `serialize()` omitted all three. After a triggerer restart the trigger was reinstantiated with defaults (`dataset_id=None`, `table_id=None`, `poll_interval=4.0`), silently changing the polling cadence and dropping the templated table identity for any task that customised them. Add the three fields to `serialize()` so the trigger round-trips through `serialize()` -> `BigQueryIntervalCheckTrigger(**kwargs)` cleanly. Extend the existing serialization test with the new keys and add a round-trip test that mirrors the pattern used by the sibling fixes in apache#66965 / apache#66966 / apache#66968. related: apache#66961
boring-cyborg
Bot
added
area:providers
provider:google
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Contributor
|
Already merged here: #67053 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigQueryIntervalCheckTrigger.__init__acceptsdataset_id,table_id, andpoll_intervaland stores them via the parentBigQueryInsertJobTrigger.__init__, butserialize()omitted all three. After a triggerer restart the trigger was reinstantiated with defaults (dataset_id=None,table_id=None,poll_interval=4.0), silently changing polling cadence and dropping the templated table identity for any task that customised them.This PR adds the three fields to the
serialize()payload so the trigger round-trips throughserialize()->BigQueryIntervalCheckTrigger(**kwargs)cleanly. The existing serialization test gains the three new keys, and a round-trip test mirrors the pattern used by the sibling fixes in #66965 / #66966 / #66968.This is the last of the five triggers called out in #66961; the static check that flags this class of bug is being introduced in #66960.
related: #66961
related: #66960
Was generative AI tooling used to co-author this PR?